netdev - Re: [PATCH net-next 03/10] bpf: mlx5e: Report bpf_prog ID during XDP_QUERY

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <59403757.8040002@iogearbox.net>
Date:   Tue, 13 Jun 2017 21:04:55 +0200
From:   Daniel Borkmann <daniel@...earbox.net>
To:     Martin KaFai Lau <kafai@...com>,
        Saeed Mahameed <saeedm@....mellanox.co.il>
CC:     Linux Netdev List <netdev@...r.kernel.org>,
        Alexei Starovoitov <ast@...com>,
        Kernel Team <kernel-team@...com>,
        Tariq Toukan <tariqt@...lanox.com>,
        Saeed Mahameed <saeedm@...lanox.com>
Subject: Re: [PATCH net-next 03/10] bpf: mlx5e: Report bpf_prog ID during
 XDP_QUERY_PROG

On 06/13/2017 08:49 PM, Martin KaFai Lau wrote:
> On Tue, Jun 13, 2017 at 07:04:26PM +0300, Saeed Mahameed wrote:
>> On Tue, Jun 13, 2017 at 4:00 AM, Martin KaFai Lau <kafai@...com> wrote:
>>> Add support to mlx5e to report bpf_prog ID during XDP_QUERY_PROG.
>>>
>>> Signed-off-by: Martin KaFai Lau <kafai@...com>
>>> Cc: Tariq Toukan <tariqt@...lanox.com>
>>> Cc: Saeed Mahameed <saeedm@...lanox.com>
>>> Acked-by: Alexei Starovoitov <ast@...com>
>>> Acked-by: Daniel Borkmann <daniel@...earbox.net>
>>
>> Acked-by: Saeed Mahameed <saeedm@...lanox.com>
> Thanks for reviewing, Saeed.
>
> I will respin v2 with READ_ONCE removed since
> it is already under rtnl lock per Jakub Kicinski's
> suggestion in nfp.  The situation should be similar
> in mlx5e.

Sounds good, yeah, only needed in data path wrt program
updates.