netdev - Re: [PATCH net-next v3 0/4] net: dsa: Multi-CPU ground work (v3)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20170613.161346.1504304537662026135.davem@davemloft.net>
Date:   Tue, 13 Jun 2017 16:13:46 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     f.fainelli@...il.com
Cc:     netdev@...r.kernel.org, andrew@...n.ch,
        vivien.didelot@...oirfairelinux.com, john@...ozen.org
Subject: Re: [PATCH net-next v3 0/4] net: dsa: Multi-CPU ground work (v3)

From: David Miller <davem@...emloft.net>
Date: Tue, 13 Jun 2017 16:11:13 -0400 (EDT)

> From: Florian Fainelli <f.fainelli@...il.com>
> Date: Tue, 13 Jun 2017 12:17:21 -0700
> 
>> This patch series prepares the ground for adding mutliple CPU port support to
>> DSA, and starts by removing redundant pieces of information such as
>> master_netdev which is cpu_dp->ethernet. Finally drivers are moved away from
>> directly accessing ds->dst->cpu_dp and use appropriate helper functions.
>> 
>> Note that if you have Device Tree blobs/platform configurations that are
>> currently listing multiple CPU ports, the proposed behavior in
>> dsa_ds_get_cpu_dp() will be to return the last bit set in ds->cpu_port_mask.
>> 
>> Future plans include:
>> - making dst->cpu_dp a flexible data structure (array, list, you name it)
>> - having the ability for drivers to return a default/preferred CPU port (if
>>   necessary)
>  ...
> 
> Series applied, thanks Florian.

Actually, I reverted, this introduced a warning, please build with NETPOLL
enabled:

net/dsa/slave.c: In function ‘dsa_slave_netpoll_setup’:
net/dsa/slave.c:688:21: warning: unused variable ‘ds’ [-Wunused-variable]
  struct dsa_switch *ds = p->dp->ds;