netdev - Re: [RFC PATCH net-next 10/15] bpf: Add support for changing congestion control

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20170613.171753.599206923549927704.davem@davemloft.net>
Date:   Tue, 13 Jun 2017 17:17:53 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     brakmo@...com
Cc:     netdev@...r.kernel.org, kernel-team@...com, bmatheny@...com,
        ast@...com, daniel@...earbox.net, dsa@...ulusnetworks.com
Subject: Re: [RFC PATCH net-next 10/15] bpf: Add support for changing
 congestion control

From: Lawrence Brakmo <brakmo@...com>
Date: Tue, 13 Jun 2017 10:59:59 -0700

> @@ -2698,8 +2698,15 @@ BPF_CALL_5(bpf_setsockopt, struct bpf_socket_ops_kern *, bpf_socket,
>  		}
>  	} else if (level == SOL_TCP &&
>  		   bpf_socket->sk->sk_prot->setsockopt == tcp_setsockopt) {
> -		// Place holder
> -		ret = -EINVAL;

I missed these C++ comments in an earlier patch, definitely don't use
them in kernel code.

Thanks.