netdev - Re: brcmfmac: Fix kernel oops on resume when request firmware fails.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAFqH_53v341QhUewFR5aQdZE1bPo5J5TY0G6zkXU9y0c5VEz1g@mail.gmail.com>
Date:   Tue, 13 Jun 2017 12:23:35 +0200
From:   Enric Balletbo Serra <eballetbo@...il.com>
To:     Kalle Valo <kvalo@...eaurora.org>
Cc:     Enric Balletbo i Serra <enric.balletbo@...labora.com>,
        Arend van Spriel <arend.vanspriel@...adcom.com>,
        "linux-wireless@...r.kernel.org" <linux-wireless@...r.kernel.org>,
        brcm80211-dev-list.pdl@...adcom.com, netdev@...r.kernel.org,
        linux-kernel <linux-kernel@...r.kernel.org>,
        Hante Meuleman <hante.meuleman@...adcom.com>,
        Christian Daudt <csd@...adcom.com>
Subject: Re: brcmfmac: Fix kernel oops on resume when request firmware fails.

Hello Kalle,

2017-06-13 7:54 GMT+02:00 Kalle Valo <kvalo@...eaurora.org>:
> Enric Balletbo i Serra <enric.balletbo@...labora.com> wrote:
>
>> When request firmware fails, brcmf_ops_sdio_remove is being called and
>> brcmf_bus freed. In such circumstancies if you do a suspend/resume cycle
>> the kernel hangs on resume due a NULL pointer dereference in resume
>> function.
>>
>> Steps to reproduce the problem:
>>  - modprobe brcmfmac without the firmware
>>      brcmfmac mmc1:0001:1: Direct firmware load for brcm/brcmfmac4354-sdio.bin
>>      failed with error -2
>>  - do a suspend/resume cycle (echo mem > /sys/power/state)
>>
>> Protect against the NULL pointer derefence by checking if dev_get_drvdata
>> returned a valid pointer.
>>
>> Signed-off-by: Enric Balletbo i Serra <enric.balletbo@...labora.com>
>
> My understanding is that there's a new version of this patch which fixes
> the issue. If not, let me know.
>
> Patch set to Superseded.
>

Yes there are these patch series [1] that fixes the issue, I guess
Arend is working on a v2 to fix a small issue we found.

[1] https://www.spinics.net/lists/linux-wireless/msg162762.html

> --
> https://patchwork.kernel.org/patch/9743159/
>
> https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
>

Regards,
 Enric