netdev - Re: [iproute PATCH] iproute: Remove useless check for nexthop keyword when setting RTA

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170614095709.46aac3e0@xeon-e3>
Date:   Wed, 14 Jun 2017 09:57:09 -0700
From:   Stephen Hemminger <stephen@...workplumber.org>
To:     Jakub Sitnicki <jkbs@...hat.com>
Cc:     netdev@...r.kernel.org
Subject: Re: [iproute PATCH] iproute: Remove useless check for nexthop
 keyword when setting RTA_OIF

On Wed,  7 Jun 2017 15:23:13 +0200
Jakub Sitnicki <jkbs@...hat.com> wrote:

> When modifying a route we set the RTA_OIF attribute only if a device was
> specified with "dev" or "oif" keyword. But for some unknown reason we
> earlier alternatively check also for the presence of "nexthop" keyword,
> even though it has no effect. So remove the pointless check.
> 
> Signed-off-by: Jakub Sitnicki <jkbs@...hat.com>

Makes sense, applied.