netdev - Re: [iproute2][PATCH] ip: Remove unneed header

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170614100435.30df62d3@xeon-e3>
Date:   Wed, 14 Jun 2017 10:04:35 -0700
From:   Stephen Hemminger <stephen@...workplumber.org>
To:     Changhyeok Bae <changhyeok.bae@...il.com>
Cc:     netdev@...r.kernel.org
Subject: Re: [iproute2][PATCH] ip: Remove unneed header

On Mon, 12 Jun 2017 04:33:35 +0000
Changhyeok Bae <changhyeok.bae@...il.com> wrote:

> Fix redefinition of struct ethhdr with a suitably patched musl libc
> that suppresses the kernel if_ether.h.
> 
> Signed-off-by: Changhyeok Bae <changhyeok.bae@...il.com>
> ---
>  ip/iplink_bridge.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/ip/iplink_bridge.c b/ip/iplink_bridge.c
> index cccdec1..f065b22 100644
> --- a/ip/iplink_bridge.c
> +++ b/ip/iplink_bridge.c
> @@ -13,7 +13,6 @@
>  #include <stdlib.h>
>  #include <string.h>
>  #include <netinet/in.h>
> -#include <netinet/ether.h>
>  #include <linux/if_link.h>
>  #include <linux/if_bridge.h>
>  #include <net/if.h>

Sorry, doing this causes:

iplink_bridge.c: In function ‘br_dump_bridge_id’:
iplink_bridge.c:77:2: warning: implicit declaration of function ‘ether_ntoa_r’ [-Wimplicit-function-declaration]
  ether_ntoa_r((const struct ether_addr *)id->addr, eaddr);