netdev - Re: [patch iproute2 v2 repost 2/3] tc: actions: add helpers to parse and print control actions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170614203222.3dcc183d@griffin>
Date:   Wed, 14 Jun 2017 20:32:22 +0200
From:   Jiri Benc <jbenc@...hat.com>
To:     Jiri Pirko <jiri@...nulli.us>
Cc:     netdev@...r.kernel.org, davem@...emloft.net, jhs@...atatu.com,
        xiyou.wangcong@...il.com, dsa@...ulusnetworks.com,
        edumazet@...gle.com, stephen@...workplumber.org,
        daniel@...earbox.net, alexander.h.duyck@...el.com,
        simon.horman@...ronome.com, mlxsw@...lanox.com
Subject: Re: [patch iproute2 v2 repost 2/3] tc: actions: add helpers to
 parse and print control actions

On Tue, 16 May 2017 19:29:36 +0200, Jiri Pirko wrote:
> From: Jiri Pirko <jiri@...lanox.com>
> 
> Each tc action is terminated by a control action. Each action parses and
> prints then intividually. Introduce set of helpers and allow to share
> this code.

This patch, as indicated by git bisect, broke tc if there are multiple
actions specified. This somehow non-real life reproducer (the real case
where this broke for me was more complex) works fine with 732f03461bc4:

# tc filter add dev eth0 parent 1: matchall action vlan push id 1 action drop

while with both the current net-next and with e67aba559581, the result
is:

# tc filter add dev eth0 parent 1: matchall action vlan push id 1 action drop
Bad action type action

 Jiri