netdev - Re: [Patch net] net_sched: move tcf_lock down after gen_replace

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20170614.144217.1489970097887149799.davem@davemloft.net>
Date:   Wed, 14 Jun 2017 14:42:17 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     yuval.shaia@...cle.com
Cc:     xiyou.wangcong@...il.com, netdev@...r.kernel.org,
        nicholashuber@...il.com, labbott@...hat.com, jhs@...atatu.com
Subject: Re: [Patch net] net_sched: move tcf_lock down after
 gen_replace_estimator()

From: Yuval Shaia <yuval.shaia@...cle.com>
Date: Tue, 13 Jun 2017 23:40:41 +0300

> On Tue, Jun 13, 2017 at 01:36:24PM -0700, Cong Wang wrote:
>> Laura reported a sleep-in-atomic kernel warning inside
> 
> Since you added a Reported-by tag below i don't see a reason to
> specifically mention it in commit log message.

That doesn't make any sense at all.

Part of telling the story is saying that someone reported a specific
kind of issue, and here is the problem, and here is how we solved it.

Just because there's a reported-by tag doesn't mean it's superfluous.