netdev - Re: [PATCH 0/3] wext: fix an ancient bug

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20170614.153536.450859354383251394.davem@davemloft.net>
Date:   Wed, 14 Jun 2017 15:35:36 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     johannes@...solutions.net
Cc:     linux-wireless@...r.kernel.org, netdev@...r.kernel.org,
        robert@...llahan.org
Subject: Re: [PATCH 0/3] wext: fix an ancient bug

From: Johannes Berg <johannes@...solutions.net>
Date: Wed, 14 Jun 2017 13:55:20 +0200

> Robert O'Callahan reported that since struct iwreq is smaller than
> struct ifreq, if it happens to land at the end of a mapped section
> userspace will erroneously get -EFAULT.
> 
> Bug report is https://bugzilla.kernel.org/show_bug.cgi?id=195869.
> 
> This bug is ancient, it kernel 2.1.15 was the first to contain the
> bug, and was released almost exactly 20.5 years ago.
> 
> Dave, I don't know if we should even bother sending this to stable,
> but if so, the third patch will apply by itself but not compile, a
> smaller patch consist of only the net/core/dev_ioctl.c modifications
> with a cast thrown in where the compile fails/warns due to passing
> the wrong struct type.
> 
> Should I merge this through my tree?

Agreed that -stable is probably not appropriate, and yes feel free to
merge it via your tree.

20.5 years... makes me feel old :-)