netdev - Re: [PATCH net-next 01/11] ipv6: skb_put

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1497469883.9377.6.camel@sipsolutions.net>
Date:   Wed, 14 Jun 2017 21:51:23 +0200
From:   Johannes Berg <johannes@...solutions.net>
To:     Stephen Hemminger <stephen@...workplumber.org>
Cc:     yuan linyu <cugyly@....com>, netdev@...r.kernel.org,
        "David S . Miller" <davem@...emloft.net>,
        yuan linyu <Linyu.Yuan@...atel-sbell.com.cn>
Subject: Re: [PATCH net-next 01/11] ipv6: skb_put_zero() used to optimize
 code

On Wed, 2017-06-14 at 12:14 -0700, Stephen Hemminger wrote:
> 
> > I just copied it from skb_put() - you could ask the same there? :)
> 
> My taste is to  have less casts. Never understood why so many skb_
> functions returned char *, probably a leftover from older Unix style.

I agree, for many of them it's awkward and I often just put a (void *)
cast in there ...

I guess we can just make them void, and if anyone wants it I can easily
cook up an spatch to remove casts.

johannes