netdev - Re: [PATCH iproute2 2/2] tc: m_tunnel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170614133807.2320f98b@xeon-e3>
Date:   Wed, 14 Jun 2017 13:38:07 -0700
From:   Stephen Hemminger <stephen@...workplumber.org>
To:     Jiri Benc <jbenc@...hat.com>
Cc:     netdev@...r.kernel.org, Jamal Hadi Salim <jhs@...atatu.com>,
        Cong Wang <xiyou.wangcong@...il.com>,
        Jiri Pirko <jiri@...nulli.us>
Subject: Re: [PATCH iproute2 2/2] tc: m_tunnel_key: add csum/nocsum option

On Wed, 14 Jun 2017 21:30:18 +0200
Jiri Benc <jbenc@...hat.com> wrote:

> Allows control of UDP zero checksum.
> 
> Signed-off-by: Jiri Benc <jbenc@...hat.com>
> ---
>  man/man8/tc-tunnel_key.8 | 18 ++++++++++++++++++
>  tc/m_tunnel_key.c        | 21 ++++++++++++++++++++-
>  2 files changed, 38 insertions(+), 1 deletion(-)
> 
> diff --git a/man/man8/tc-tunnel_key.8 b/man/man8/tc-tunnel_key.8
> index 2e569730abbb..e979a74715cb 100644
> --- a/man/man8/tc-tunnel_key.8
> +++ b/man/man8/tc-tunnel_key.8
> @@ -16,6 +16,7 @@ tunnel_key - Tunnel metadata manipulation
>  .IR ADDRESS
>  .BI id " KEY_ID"
>  .BI dst_port " UDP_PORT"
> +.RB "[ " csum " | " nocsum " ]"
>  
>  .SH DESCRIPTION
>  The
> @@ -77,6 +78,23 @@ Outer header destination IP address (IPv4 or IPv6)
>  .TP
>  .B dst_port
>  Outer header destination UDP port
> +.TP
> +.RB [ no ] csum
> +Controlls outer UDP checksum. When set to
> +.B csum
> +(which is default), the outer UDP checksum is calculated and included in the
> +packets. When set to
> +.BR nocsum ,

Does this change the default? Before your patches what was the checksum
setting for the new tunnel.