netdev - Re: [PATCH net-next] net/mlxfw: fix a NULL dereference

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9ca5d66f-3eed-444a-61c8-269f55945be7@mellanox.com>
Date:   Wed, 14 Jun 2017 14:03:23 +0300
From:   Yotam Gigi <yotamg@...lanox.com>
To:     Dan Carpenter <dan.carpenter@...cle.com>
Cc:     netdev@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH net-next] net/mlxfw: fix a NULL dereference

On 06/14/2017 01:41 PM, Dan Carpenter wrote:
> If we hit this error path we end up returning ERR_PTR(0) which is NULL.
> The caller is not expecting that so it results in a NULL dereference.
>
> Fixes: 410ed13cae39 ("Add the mlxfw module for Mellanox firmware flash process")
> Signed-off-by: Dan Carpenter <dan.carpenter@...cle.com>
>
> diff --git a/drivers/net/ethernet/mellanox/mlxfw/mlxfw_mfa2.c b/drivers/net/ethernet/mellanox/mlxfw/mlxfw_mfa2.c
> index 628150d28061..993cb5ba934e 100644
> --- a/drivers/net/ethernet/mellanox/mlxfw/mlxfw_mfa2.c
> +++ b/drivers/net/ethernet/mellanox/mlxfw/mlxfw_mfa2.c
> @@ -594,6 +594,7 @@ struct mlxfw_mfa2_component *
>  	if (memcmp(comp_data->buff, mlxfw_mfa2_comp_magic,
>  		   mlxfw_mfa2_comp_magic_len) != 0) {
>  		pr_err("Component has wrong magic\n");
> +		err = -EINVAL;
>  		goto err_out;
>  	}
>  


Acked-by: Yotam Gigi <yotamg@...lanox.com>