netdev - Re: [PATCH iproute2] ip: mroute: Add table output to show command

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <eedea7e1-f2bc-d830-6da5-ec53e042845e@cumulusnetworks.com>
Date:   Wed, 14 Jun 2017 15:53:47 +0300
From:   Nikolay Aleksandrov <nikolay@...ulusnetworks.com>
To:     Donald Sharp <sharpd@...ulusnetworks.com>, netdev@...r.kernel.org,
        stephen@...workplumber.org
Subject: Re: [PATCH iproute2] ip: mroute: Add table output to show command

On 14/06/17 15:08, Donald Sharp wrote:
> When the user specifies `table all` or `table 0` to
> the `ip mroute show` command we dump the entirety of
> the known mroute tables.  Without some sort of
> divisor to tell us what table we are looking at
> the command is useless.
> 
> Add `Table: <vrf name>` to the output of 'ip mroute show table 0'
> 
> Follow the convention established by 'ip route show table 0'
> for when to display
> 
> Signed-off-by: Donald Sharp <sharpd@...ulusnetworks.com>
> ---
>  ip/ipmroute.c | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/ip/ipmroute.c b/ip/ipmroute.c
> index 4d2d758..70f4c4f 100644
> --- a/ip/ipmroute.c
> +++ b/ip/ipmroute.c
> @@ -189,6 +189,11 @@ int print_mroute(const struct sockaddr_nl *who, struct nlmsghdr *n, void *arg)
>  		fprintf(fp, ", Age %4i.%.2i", (int)tv.tv_sec,
>  			(int)tv.tv_usec/10000);
>  	}
> +
> +	if (table && (table != RT_TABLE_MAIN || show_details > 0) && !filter.tb)
> +		fprintf(fp, " Table: %s",
> +			rtnl_rttable_n2a(table, b1, sizeof(b1)));
> +
>  	fprintf(fp, "\n");
>  	fflush(fp);
>  	return 0;
> 

LGTM, thanks!

Reviewed-by: Nikolay Aleksandrov <nikolay@...ulusnetworks.com>