netdev - Re: [PATCH] af_iucv: Move sockaddr length checks to before accessing sa

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <a2bafded-712e-6e8b-9395-b020c73dc06a@linux.vnet.ibm.com>
Date:   Wed, 14 Jun 2017 16:49:06 +0200
From:   Julian Wiedmann <jwi@...ux.vnet.ibm.com>
To:     Mateusz Jurczyk <mjurczyk@...gle.com>,
        Ursula Braun <ubraun@...ux.vnet.ibm.com>,
        "David S. Miller" <davem@...emloft.net>,
        linux-s390@...r.kernel.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] af_iucv: Move sockaddr length checks to before accessing
 sa_family in bind and connect handlers

On 06/13/2017 07:42 PM, Mateusz Jurczyk wrote:
> Verify that the caller-provided sockaddr structure is large enough to
> contain the sa_family field, before accessing it in bind() and connect()
> handlers of the AF_IUCV socket. Since neither syscall enforces a minimum
> size of the corresponding memory region, very short sockaddrs (zero or
> one byte long) result in operating on uninitialized memory while
> referencing .sa_family.
> 
> Signed-off-by: Mateusz Jurczyk <mjurczyk@...gle.com>
Thanks Mateusz!

Fixes: 52a82e23b9f2
Acked-by: Julian Wiedmann <jwi@...ux.vnet.ibm.com>