netdev - Re: [PATCH net-next] nfp: add VLAN filtering support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20170615.104645.2226445663454733772.davem@davemloft.net>
Date:   Thu, 15 Jun 2017 10:46:45 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     Yuval.Mintz@...ium.com
Cc:     jakub.kicinski@...ronome.com, netdev@...r.kernel.org,
        oss-drivers@...ronome.com, pablo.cascon@...ronome.com
Subject: Re: [PATCH net-next] nfp: add VLAN filtering support

From: "Mintz, Yuval" <Yuval.Mintz@...ium.com>
Date: Thu, 15 Jun 2017 12:50:57 +0000

>> From: Pablo Cascón <pablo.cascon@...ronome.com>
>> 
>> Add general use per-vNIC mailbox area and use it for VLAN filtering support.
>> Initially proto is hardcoded to 802.1q.
>> 
> ...
>> +static int
>> +nfp_net_vlan_rx_add_vid(struct net_device *netdev, __be16 proto, u16
>> +vid) {
>> +	struct nfp_net *nn = netdev_priv(netdev);
>> +
>> +	/* Priority tagged packets with vlan id 0 are processed by the
>> +	 * NFP as untagged packets
>> +	 */
>> +	if (!vid)
>> +		return 0;
>> +
>> +	nn_writew(nn, NFP_NET_CFG_VLAN_FILTER_VID, vid);
>> +	nn_writew(nn, NFP_NET_CFG_VLAN_FILTER_PROTO, ETH_P_8021Q);
> 
> If it's hard-coded, don't you want to fail the request in case proto is different?

Agreed.