netdev - Re: [PATCH net] sctp: fix spinfo_srtt to be in msecs and not jiffies

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20170615.121557.573870132240215519.davem@davemloft.net>
Date:   Thu, 15 Jun 2017 12:15:57 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     marcelo.leitner@...il.com
Cc:     netdev@...r.kernel.org, vyasevich@...il.com, nhorman@...driver.com,
        linux-sctp@...r.kernel.org
Subject: Re: [PATCH net] sctp: fix spinfo_srtt to be in msecs and not
 jiffies

From: Marcelo Ricardo Leitner <marcelo.leitner@...il.com>
Date: Wed, 14 Jun 2017 16:08:59 -0300

> RFC 6458 (SCTP Sockets API) Section 8.2.2.  Peer Address Information
> (SCTP_GET_PEER_ADDR_INFO) defines that spinfo_srtt is in miliseconds,
> yet we were using it in jiffies.
> 
> Fix it by converting before assigning, similarly to RTO.
> 
> Signed-off-by: Marcelo Ricardo Leitner <marcelo.leitner@...il.com>
> ---
> I hope this is not considered UAPI breakage. This is exported via
> getsockopt() calls.

Unfortunately it is UAPI breakage, it is too late to change this now.

SOrry.