netdev - Re: [PATCH net-next 0/2] net: sched: act_tunnel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20170615.142126.2291497856328892133.davem@davemloft.net>
Date:   Thu, 15 Jun 2017 14:21:26 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     jbenc@...hat.com
Cc:     netdev@...r.kernel.org, jhs@...atatu.com, xiyou.wangcong@...il.com,
        jiri@...nulli.us
Subject: Re: [PATCH net-next 0/2] net: sched: act_tunnel_key: UDP checksums

From: Jiri Benc <jbenc@...hat.com>
Date: Wed, 14 Jun 2017 21:19:29 +0200

> Currently, the tunnel_key tc action does not set TUNNEL_CSUM, thus
> transmitting packets with zero UDP checksum. This is inconsistent with how
> we treat non-lwt UDP tunnels where the default is to fill in the UDP
> checksum. Non-zero UDP checksum is the better default anyway for various
> reasons previously discussed.
> 
> Make this configurable for the tunnel_key tc action with the default being
> non-zero checksum. Saves a lot of surprises especially with IPv6.
> 
> Signed-off-by: Jiri Benc <jbenc@...hat.com>

Seems reasonable, series applied, thanks.