netdev - RE: [RFC] networking: convert many more places to skb_put

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <8729016553E3654398EA69218DA29EEF15BC8F99@cnshjmbx02>
Date:   Thu, 15 Jun 2017 07:47:53 +0000
From:   YUAN Linyu <Linyu.Yuan@...atel-sbell.com.cn>
To:     Johannes Berg <johannes@...solutions.net>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: RE: [RFC] networking: convert many more places to skb_put_zero()

Ok, understand 

> -----Original Message-----
> From: Johannes Berg [mailto:johannes@...solutions.net]
> Sent: Thursday, June 15, 2017 3:45 PM
> To: YUAN Linyu; netdev@...r.kernel.org
> Subject: Re: [RFC] networking: convert many more places to skb_put_zero()
> 
> On Thu, 2017-06-15 at 07:20 +0000, YUAN Linyu wrote:
> > >
> > In my opinion if spatch can do it even it found one place, keep it.
> > Only leave difficult places like ndisc.c to me.
> 
> It's not so simple - I'd have to tailor the spatch to it pretty much I
> guess, spending far more time on the spatch than the single place
> warrants.
> 
> > > Btw, just made a patch to add and use "skb_put_data()", just doing
> > > a
> > > memcpy() into the skb_put() area also has lots of users.
> >
> > Yes, I also notice some places.
> 
> I sent a patch.
> 
> johannes