netdev - Re: [PATCH iproute2 net] iproute: fix compilation issue with older glibc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170616090439.525c2f9a@xeon-e3>
Date:   Fri, 16 Jun 2017 09:04:39 -0700
From:   Stephen Hemminger <stephen@...workplumber.org>
To:     David Lebrun <david.lebrun@...ouvain.be>
Cc:     <netdev@...r.kernel.org>
Subject: Re: [PATCH iproute2 net] iproute: fix compilation issue with older
 glibc

On Fri, 16 Jun 2017 15:54:28 +0200
David Lebrun <david.lebrun@...ouvain.be> wrote:

> If a header that includes linux/in6.h is included before
> iproute's utils.h, then iproute2 fails to compile on older
> glibc versions.
> 
> Fixes: e8493916a8ede9970732e33ea52d30b83071f401 ("iproute: add support for SR-IPv6 lwtunnel encapsulation")
> Reported-by: Daniel Borkmann <daniel@...earbox.net>
> Signed-off-by: David Lebrun <david.lebrun@...ouvain.be>

Looks good, almost always best to remove #ifdef's if possible.
Applied