netdev - Re: [RFC 3/3] networking: make skb_push & __skb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1497605088.2622.6.camel@sipsolutions.net>
Date:   Fri, 16 Jun 2017 11:24:48 +0200
From:   Johannes Berg <johannes@...solutions.net>
To:     Joe Perches <joe@...ches.com>, netdev@...r.kernel.org
Subject: Re: [RFC 3/3] networking: make skb_push & __skb_push return void
 pointers

On Fri, 2017-06-16 at 02:19 -0700, Joe Perches wrote:
> 
> >  			if (frag_size  ==
> > PN533_CMD_DATAFRAME_MAXLEN)
> > -				*skb_push(frag, sizeof(u8)) =
> > -							(PN533_CMD
> > _MI_MASK | 1);
> > -			else
> > -				*skb_push(frag, sizeof(u8)) =  1;
> > /* TG */
> > +				*(u8 *)skb_push(frag, sizeof(u8))
> > =
> > +									
> > (PN533_CMD_MI_MASK | 1);
> > +				else
> > +					*(u8 *)skb_push(frag,
> > sizeof(u8)) =  1; /* TG */
> 
> Can you check all the if/else uses.
> This one is not formatted correctly.
> I didn't look at any others.

Hmm, that's annoying. I did fix up a few, but I guess I missed this
one.

johannes