netdev - RE: [PATCH net-next 4/7] qed*: Rename qede

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <BLUPR0701MB2004F40778215AD277D4FF348DC10@BLUPR0701MB2004.namprd07.prod.outlook.com>
Date:   Fri, 16 Jun 2017 12:41:15 +0000
From:   "Mintz, Yuval" <Yuval.Mintz@...ium.com>
To:     kbuild test robot <lkp@...el.com>,
        "davem@...emloft.net" <davem@...emloft.net>
CC:     "kbuild-all@...org" <kbuild-all@...org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-rdma@...r.kernel.org" <linux-rdma@...r.kernel.org>,
        "Kalderon, Michal" <Michal.Kalderon@...ium.com>
Subject: RE: [PATCH net-next 4/7] qed*: Rename qede_roce.[ch]

>    In file included from drivers/net//ethernet/qlogic/qede/qede.h:43:0,
>                     from drivers/net//ethernet/qlogic/qede/qede_ptp.h:38,
>                     from drivers/net//ethernet/qlogic/qede/qede_fp.c:43:
> >> include/linux/qed/qede_rdma.h:57:12: warning: 'struct pci_dev' declared
> inside parameter list [enabled by default]
> >> include/linux/qed/qede_rdma.h:57:12: warning: its scope is only this
> definition or declaration, which is probably not what you want [enabled by
> default]

This patch is merely renaming qede_roce.h -> qede_rdma.h.
I guess the kbuild test robot got better scripts than the time we've added qede_rdma.h,
or else it would have catched the fact there are no inclusion since then.

Dave - given this is an existing warning exposed due to a rename [and not something
that actually got introduced in this patch], do you want us to fix it via v2 of this series?
Or send a fix for it later?