netdev - [PATCH net-next] tls: update Kconfig

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170617152513.GA45696@davejwatson-mba.dhcp.thefacebook.com>
Date:   Sat, 17 Jun 2017 08:25:13 -0700
From:   Dave Watson <davejwatson@...com>
To:     David Miller <davem@...emloft.net>, <netdev@...r.kernel.org>,
        <kbuild-all@...org>, Boris Pismenny <borisp@...lanox.com>,
        Ilya Lesokhin <ilyal@...lanox.com>,
        Aviad Yehezkel <aviadye@...lanox.com>
CC:     Stephen Hemminger <stephen@...workplumber.org>
Subject: [PATCH net-next] tls: update Kconfig

Missing crypto deps for some platforms.
Default to n for new module.

config: m68k-amcore_defconfig (attached as .config)
compiler: m68k-linux-gcc (GCC) 4.9.0

make.cross ARCH=m68k
All errors (new ones prefixed by >>):

   net/built-in.o: In function `tls_set_sw_offload':
>> (.text+0x732f8): undefined reference to `crypto_alloc_aead'
   net/built-in.o: In function `tls_set_sw_offload':
>> (.text+0x7333c): undefined reference to `crypto_aead_setkey'
   net/built-in.o: In function `tls_set_sw_offload':
>> (.text+0x73354): undefined reference to `crypto_aead_setauthsize'

Reported-by: kbuild test robot <fengguang.wu@...el.com>
Signed-off-by: Dave Watson <davejwatson@...com>
---
 net/tls/Kconfig | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/net/tls/Kconfig b/net/tls/Kconfig
index b13541f..eb58303 100644
--- a/net/tls/Kconfig
+++ b/net/tls/Kconfig
@@ -4,9 +4,12 @@
 config TLS
 	tristate "Transport Layer Security support"
 	depends on INET
-	default m
+	select CRYPTO
+	select CRYPTO_AES
+	select CRYPTO_GCM
+	default n
 	---help---
 	Enable kernel support for TLS protocol. This allows symmetric
 	encryption handling of the TLS protocol to be done in-kernel.
 
-	If unsure, say M.
+	If unsure, say N.
-- 
2.9.3