netdev - Re: [PATCH net-next] net: dsa: Fix legacy probing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87d1a2pkmz.fsf@weeman.i-did-not-set--mail-host-address--so-tickle-me>
Date:   Sat, 17 Jun 2017 13:52:04 -0400
From:   Vivien Didelot <vivien.didelot@...oirfairelinux.com>
To:     Florian Fainelli <f.fainelli@...il.com>, netdev@...r.kernel.org
Cc:     davem@...emloft.net, andrew@...n.ch, jcobham@...stertangent.com,
        Florian Fainelli <f.fainelli@...il.com>
Subject: Re: [PATCH net-next] net: dsa: Fix legacy probing

Florian Fainelli <f.fainelli@...il.com> writes:

> After commit 6d3c8c0dd88a ("net: dsa: Remove master_netdev and
> use dst->cpu_dp->netdev") and a29342e73911 ("net: dsa: Associate
> slave network device with CPU port") we would be seeing NULL pointer
> dereferences when accessing dst->cpu_dp->netdev too early. In the legacy
> code, we actually know early in advance the master network device, so
> pass it down to the relevant functions.
>
> Fixes: 6d3c8c0dd88a ("net: dsa: Remove master_netdev and use dst->cpu_dp->netdev")
> Fixes: a29342e73911 ("net: dsa: Associate slave network device with CPU port")
> Reported-by: Jason Cobham <jcobham@...stertangent.com>
> Tested-by: Jason Cobham <jcobham@...stertangent.com>
> Signed-off-by: Florian Fainelli <f.fainelli@...il.com>

Reviewed-by: Vivien Didelot <vivien.didelot@...oirfairelinux.com>