netdev - Re: [PATCH net 0/4] macvlan: Fix some issues with changing mac addresses

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <106769ec-3721-b461-43d4-65dea397a197@oracle.com>
Date:   Fri, 16 Jun 2017 22:23:41 -0700
From:   Girish Moodalbail <girish.moodalbail@...cle.com>
To:     Vladislav Yasevich <vyasevich@...il.com>, netdev@...r.kernel.org
Cc:     Vladislav Yasevich <vyasevic@...hat.com>
Subject: Re: [PATCH net 0/4] macvlan: Fix some issues with changing mac
 addresses

On 6/16/17 6:36 AM, Vladislav Yasevich wrote:
> There are some issues in macvlan wrt to changing it's mac address.
> * An error is returned in the specified address is the same as an already
>   assigned address.
> * In passthru mode, the mac address of the macvlan device doesn't change.
> * After changing the mac address of a passthru macvlan and then removing it,
>   the mac address of the physical device remains changed.
>
> This patch series attempts to resolve these issues.
>
> Thanks
> -vlad
>
> Vladislav Yasevich (4):
>   macvlan: Do not return error when setting the same mac address
>   macvlan: Fix passthru macvlan mac address inheritance
>   macvlan: convert port passthru to flags.

Above 3 patches looks good to me, so

Reviewed-by: Girish Moodalbail <girish.moodalbail@...cle.com>


>   macvlan: Let passthru macvlan correctly restore lower mac address

However, I have few questions/comments on the above patch.

thanks,
~Girish

>
>  drivers/net/macvlan.c | 85 ++++++++++++++++++++++++++++++++++++++++++---------
>  1 file changed, 71 insertions(+), 14 deletions(-)
>