netdev - Re: [PATCH net] net: 8021q: Fix one possible panic caused by BUG_ON in free

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20170619.141036.665343734571702647.davem@davemloft.net>
Date:   Mon, 19 Jun 2017 14:10:36 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     gfree.wind@....163.com
Cc:     netdev@...r.kernel.org
Subject: Re: [PATCH net] net: 8021q: Fix one possible panic caused by
 BUG_ON in free_netdev

From: gfree.wind@....163.com
Date: Fri, 16 Jun 2017 15:00:02 +0800

> From: Gao Feng <gfree.wind@....163.com>
> 
> The register_vlan_device would invoke free_netdev directly, when
> register_vlan_dev failed. It would trigger the BUG_ON in free_netdev
> if the dev was already registered. In this case, the netdev would be
> freed in netdev_run_todo later.
> 
> So add one condition check now. Only when dev is not registered, then
> free it directly.
> 
> The following is the part coredump when netdev_upper_dev_link failed
> in register_vlan_dev. I removed the lines which are too long.
 ...
> Signed-off-by: Gao Feng <gfree.wind@....163.com>

Ok, I guess this is how we will have to fix this.

Applied, thanks.