lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 18 Jun 2017 22:43:49 -0700 From: Pravin Shelar <pshelar@....org> To: Haishuang Yan <yanhaishuang@...s.chinamobile.com> Cc: "David S. Miller" <davem@...emloft.net>, Paolo Abeni <pabeni@...hat.com>, Alexei Starovoitov <ast@...com>, Linux Kernel Network Developers <netdev@...r.kernel.org>, linux-kernel@...r.kernel.org, Pravin B Shelar <pshelar@...ira.com> Subject: Re: [PATCH v2 1/2] ip_tunnel: fix ip tunnel lookup in collect_md mode On Fri, Jun 16, 2017 at 8:27 PM, Haishuang Yan <yanhaishuang@...s.chinamobile.com> wrote: > In collect_md mode, if the tun dev is down, it still can call > ip_tunnel_rcv to receive on packets, and the rx statistics increase > improperly. > > Fixes: 2e15ea390e6f ("ip_gre: Add support to collect tunnel metadata.") > Cc: Pravin B Shelar <pshelar@...ira.com> > Signed-off-by: Haishuang Yan <yanhaishuang@...s.chinamobile.com> > > --- > Change since v2: > * Fix wrong recipient addresss > --- > net/ipv4/ip_tunnel.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/net/ipv4/ip_tunnel.c b/net/ipv4/ip_tunnel.c > index 0f1d876..a3caba1 100644 > --- a/net/ipv4/ip_tunnel.c > +++ b/net/ipv4/ip_tunnel.c > @@ -176,7 +176,7 @@ struct ip_tunnel *ip_tunnel_lookup(struct ip_tunnel_net *itn, > return cand; > > t = rcu_dereference(itn->collect_md_tun); > - if (t) > + if (t && (t->dev->flags & IFF_UP)) > return t; > It would be nice if we could increment drop count if tunnel device is not up.
Powered by blists - more mailing lists