netdev - Re: [PATCH net-next] enic: use kasprintf instead of snprintf

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sun, 18 Jun 2017 22:55:20 -0700
From:   Govindarajulu Varadarajan <gvaradar@...co.com>
To:     Joe Perches <joe@...ches.com>
CC:     <davem@...emloft.net>, <netdev@...r.kernel.org>, <benve@...co.com>
Subject: Re: [PATCH net-next] enic: use kasprintf instead of snprintf

On Sun, 18 Jun 2017, Joe Perches wrote:

> Perhaps it'd be better to use a style
> with a variable length format precision
>
> ie:
>
> 	"%.*s-tx-%u", IFNAMSIZ - 4 - <something>, netdev-name, i)
>

This would truncate interface name. Why is this preferred to my patch?