netdev - Re: [PATCH net-next 09/13] net: ena: adding missing cast in ena_com_mem_addr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1497876308540.71961@amazon.com>
Date:   Mon, 19 Jun 2017 12:45:08 +0000
From:   "Belgazal, Netanel" <netanel@...zon.com>
To:     Leon Romanovsky <leon@...nel.org>
CC:     "davem@...emloft.net" <davem@...emloft.net>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "Woodhouse, David" <dwmw@...zon.co.uk>,
        "Machulsky, Zorik" <zorik@...zon.com>,
        "Matushevsky, Alexander" <matua@...zon.com>,
        "BSHARA, Said" <saeedb@...zon.com>,
        "Wilson, Matt" <msw@...zon.com>,
        "Liguori, Anthony" <aliguori@...zon.com>,
        "Bshara, Nafea" <nafea@...zon.com>,
        "Schmeilin, Evgeny" <evgenys@...zon.com>
Subject: Re: [PATCH net-next 09/13] net: ena: adding missing cast in
 ena_com_mem_addr_set()

Ack,

Will use the proposed functions.
________________________________________
From: Leon Romanovsky <leon@...nel.org>
Sent: Monday, June 19, 2017 8:00 AM
To: Belgazal, Netanel
Cc: davem@...emloft.net; netdev@...r.kernel.org; Woodhouse, David; Machulsky, Zorik; Matushevsky, Alexander; BSHARA, Said; Wilson, Matt; Liguori, Anthony; Bshara, Nafea; Schmeilin, Evgeny
Subject: Re: [PATCH net-next 09/13] net: ena: adding missing cast in ena_com_mem_addr_set()

On Sun, Jun 18, 2017 at 02:28:14PM +0300, netanel@...zon.com wrote:
> From: Netanel Belgazal <netanel@...zon.com>
>
> Signed-off-by: Netanel Belgazal <netanel@...zon.com>
> ---
>  drivers/net/ethernet/amazon/ena/ena_com.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/amazon/ena/ena_com.c b/drivers/net/ethernet/amazon/ena/ena_com.c
> index f6e1d30523a6..8efb85e25a42 100644
> --- a/drivers/net/ethernet/amazon/ena/ena_com.c
> +++ b/drivers/net/ethernet/amazon/ena/ena_com.c
> @@ -100,7 +100,7 @@ static inline int ena_com_mem_addr_set(struct ena_com_dev *ena_dev,
>       }
>
>       ena_addr->mem_addr_low = (u32)addr;
> -     ena_addr->mem_addr_high = (u64)addr >> 32;
> +     ena_addr->mem_addr_high = (u16)((u64)addr >> 32);

We have macro for getting upper 32 bits - upper_32_bits(addr), the same
goes for lower 32 bits.

>
>       return 0;
>  }
> --
> 2.7.4
>