netdev - Re: [PATCH 2/2] net/core: remove explicit do_softirq() from busy_poll

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 20 Jun 2017 13:09:45 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     bigeasy@...utronix.de
Cc:     edumazet@...gle.com, netdev@...r.kernel.org, tglx@...utronix.de
Subject: Re: [PATCH 2/2] net/core: remove explicit do_softirq() from
 busy_poll_stop()

From: Sebastian Andrzej Siewior <bigeasy@...utronix.de>
Date: Fri, 16 Jun 2017 19:24:00 +0200

> Since commit 217f69743681 ("net: busy-poll: allow preemption in
> sk_busy_loop()") there is an explicit do_softirq() invocation after
> local_bh_enable() has been invoked.
> I don't understand why we need this because local_bh_enable() will
> invoke do_softirq() once the softirq counter reached zero and we have
> softirq-related work pending.
> 
> Signed-off-by: Sebastian Andrzej Siewior <bigeasy@...utronix.de>

This indeed is superfluous, applied, thanks.