netdev - Re: [RFC 2/2] net-next: mt7530: add nh and proto offsets to the ops struct

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0c30b590-19b1-8648-eea1-943724c60941@phrozen.org>
Date:   Tue, 20 Jun 2017 19:27:23 +0200
From:   John Crispin <john@...ozen.org>
To:     Andrew Lunn <andrew@...n.ch>
Cc:     Vivien Didelot <vivien.didelot@...oirfairelinux.com>,
        Florian Fainelli <f.fainelli@...il.com>,
        "David S . Miller" <davem@...emloft.net>,
        Sean Wang <sean.wang@...iatek.com>, netdev@...r.kernel.org
Subject: Re: [RFC 2/2] net-next: mt7530: add nh and proto offsets to the ops
 struct



On 20/06/17 15:54, Andrew Lunn wrote:
> On Tue, Jun 20, 2017 at 10:06:55AM +0200, John Crispin wrote:
>> The MT7530 inserts the 4 magic header in between the 802.3 address and
>> protocol field. The patch defines these header such that the flow_disector
>> can properly parse the packet and thus allows hashing to function properly.
> This is to do with tagging, not the switch driver. The Marvell switch
> driver can be used with two different tagging protocols.
>
> So i would put these fields in the dsa_device_ops.
>
>     Andrew
Hi Andrew,

i originally did so but struct dsa_device_ops is defined inside 
net/dsa/dsa_priv.h so flow_dissector.c would need a

#include "../dsa/dsa_priv.h"

I was not sure if this is ok or if we would need to move the struct 
definition to include/net/dsa.h in that case

     John