netdev - Re: [PATCH net-next] ibmvnic: Return from ibmvnic_resume if not in VNIC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <3d0baa3a-6c7a-8c12-f695-ec73c15159f2@linux.vnet.ibm.com>
Date:   Tue, 20 Jun 2017 12:36:23 -0500
From:   Nathan Fontenot <nfont@...ux.vnet.ibm.com>
To:     John Allen <jallen@...ux.vnet.ibm.com>, netdev@...r.kernel.org
Cc:     Thomas Falcon <tlfalcon@...ux.vnet.ibm.com>
Subject: Re: [PATCH net-next] ibmvnic: Return from ibmvnic_resume if not in
 VNIC_OPEN state



On 06/19/2017 11:27 AM, John Allen wrote:
> If the ibmvnic driver is not in the VNIC_OPEN state, return from
> ibmvnic_resume callback. If we are not in the VNIC_OPEN state, interrupts
> may not be initialized and directly calling the interrupt handler will
> cause a crash.
> 
> Signed-off-by: John Allen <jallen@...ux.vnet.ibm.com>

Reviewed-by: Nathan Fontenot <nfont@...ux.vnet.ibm.com>

> ---
> diff --git a/drivers/net/ethernet/ibm/ibmvnic.c b/drivers/net/ethernet/ibm/ibmvnic.c
> index 722daf5..0135095 100644
> --- a/drivers/net/ethernet/ibm/ibmvnic.c
> +++ b/drivers/net/ethernet/ibm/ibmvnic.c
> @@ -3859,6 +3859,9 @@ static int ibmvnic_resume(struct device *dev)
>  	struct ibmvnic_adapter *adapter = netdev_priv(netdev);
>  	int i;
> 
> +	if (adapter->state != VNIC_OPEN)
> +		return 0;
> +
>  	/* kick the interrupt handlers just in case we lost an interrupt */
>  	for (i = 0; i < adapter->req_rx_queues; i++)
>  		ibmvnic_interrupt_rx(adapter->rx_scrq[i]->irq,
>