netdev - Re: [PATCH] liquidio: stop using huge static buffer, save 4096k in .data

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20170620.152142.1443468587541525646.davem@davemloft.net>
Date:   Tue, 20 Jun 2017 15:21:42 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     dvlasenk@...hat.com
Cc:     netdev@...r.kernel.org, felix.manlunas@...ium.com,
        prasad.kanneganti@...ium.com, derek.chickles@...ium.com,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] liquidio: stop using huge static buffer, save 4096k in
 .data

From: Denys Vlasenko <dvlasenk@...hat.com>
Date: Mon, 19 Jun 2017 21:50:52 +0200

> Only compile-tested - I don't have the hardware.
> 
> From code inspection, octeon_pci_write_core_mem() appears to be safe wrt
> unaligned source. In any case, u8 fbuf[] was not guaranteed to be aligned
> anyway.
> 
> Signed-off-by: Denys Vlasenko <dvlasenk@...hat.com>

Looks good to me but I'll let one of the liquidio guys review this first
before I apply it.