netdev - Re: [PATCH net] sfc: remove duplicate up_write on VF filter

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20170620.154021.1071172261400917698.davem@davemloft.net>
Date:   Tue, 20 Jun 2017 15:40:21 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     ecree@...arflare.com
Cc:     linux-net-drivers@...arflare.com, netdev@...r.kernel.org
Subject: Re: [PATCH net] sfc: remove duplicate up_write on VF filter_sem

From: Edward Cree <ecree@...arflare.com>
Date: Tue, 20 Jun 2017 13:08:51 +0100

> Somehow two copies of the line 'up_write(&vf->efx->filter_sem);' got into
>  efx_ef10_sriov_set_vf_vlan().  This would put the mutex in a bad state and
>  cause all subsequent down attempts to hang.
> 
> Fixes: 671b53eec2ed ("sfc: Ensure down_write(&filter_sem) and up_write() are matched before calling efx_net_open()")
> Signed-off-by: Edward Cree <ecree@...arflare.com>

Applied and queued up for -stable.