netdev - Re: [PATCH] [PATCH v2 net-next] bonding: Convert multiple netdev_info messages to netdev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1498001282.12185.2.camel@perches.com>
Date:   Tue, 20 Jun 2017 16:28:02 -0700
From:   Joe Perches <joe@...ches.com>
To:     Michael J Dilmore <michael.j.dilmore@...il.com>,
        j.vosburgh@...il.com
Cc:     vfalico@...il.com, andy@...yhouse.net, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] [PATCH v2 net-next] bonding: Convert multiple
 netdev_info messages to netdev_dbg

On Tue, 2017-06-20 at 23:05 +0100, Michael J Dilmore wrote:
> The bond_options.c file contains several netdev_info messages that clutter kernel output. This patch changes all netdev_info messages
> to netdev_dbg and adds a netdev debug for the packets per slave parameter.

Hey Michael.

You should realign the multiple-line statements
to the open parentheses.

cheers, Joe

> diff --git a/drivers/net/bonding/bond_options.c b/drivers/net/bonding/bond_options.c
[]
> @@ -721,13 +721,13 @@ static int bond_option_mode_set(struct bonding *bond,
>  				const struct bond_opt_value *newval)
>  {
>  	if (!bond_mode_uses_arp(newval->value) && bond->params.arp_interval) {
> -		netdev_info(bond->dev, "%s mode is incompatible with arp monitoring, start mii monitoring\n",
> +		netdev_dbg(bond->dev, "%s mode is incompatible with arp monitoring, start mii monitoring\n",
>  			    newval->string);

Now all these are not aligned properly.

etc...