netdev - RE: [net-next 11/15] net/mlx5e: Reduce number of heap allocated buffers for update stats

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 20 Jun 2017 12:36:12 +0000
From:   David Laight <David.Laight@...LAB.COM>
To:     'Saeed Mahameed' <saeedm@...lanox.com>,
        "David S. Miller" <davem@...emloft.net>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        Gal Pressman <galp@...lanox.com>,
        "kernel-team@...com" <kernel-team@...com>
Subject: RE: [net-next 11/15] net/mlx5e: Reduce number of heap allocated
 buffers for update stats

From: Saeed Mahameed
> Sent: 15 June 2017 22:43
> Allocating buffers on the heap every 200ms is something we should avoid,
> let's use buffers located on the stack instead.
...
> +	u32 in[MLX5_ST_SZ_DW(ppcnt_reg)] = {0};

How big is that?

Allocating large on-stack buffers is even worse.

One kzalloc() every 200ms isn't going to be noticeable.

	David