netdev - RE: [PATCH rdma-next 07/19] RDMA/core: Add iterator over ib

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 21 Jun 2017 09:07:35 -0500
From:   "Steve Wise" <swise@...ngridcomputing.com>
To:     "'Leon Romanovsky'" <leon@...nel.org>,
        "'Doug Ledford'" <dledford@...hat.com>
Cc:     <linux-rdma@...r.kernel.org>,
        "'Chien Tin Tung'" <chien.tin.tung@...el.com>,
        "'Stephen Hemminger'" <stephen@...workplumber.org>,
        "'Jiri Pirko'" <jiri@...lanox.com>,
        "'Ariel Almog'" <ariela@...lanox.com>,
        "'Linux Netdev'" <netdev@...r.kernel.org>,
        "'Leon Romanovsky'" <leonro@...lanox.com>
Subject: RE: [PATCH rdma-next 07/19] RDMA/core: Add iterator over ib_devices

> From: Leon Romanovsky <leonro@...lanox.com>
> 
> The coming nldev needs iterate over all IB devices in the system
> and in order do not expose the ib_devices list outside the devices.c,
> it is necessary to provide function iterator.

nit: "needs iterate over" -> "needs to iterate over..."
nit: "order do" -> "order to"

> 
> Current version is written explicitly for nldev callback to avoid
> over-engineering at this stage, but it can be easily extended for
> other types.
> 
> Signed-off-by: Leon Romanovsky <leonro@...lanox.com>


Reviewed-by: Steve Wise <swise@...ngridcomputing.com>