netdev - RE: [PATCH rdma-next 13/19] RDMA/netlink: Add netlink device definitions to UAPI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <022e01d2ea99$a2594160$e70bc420$@opengridcomputing.com>
Date:   Wed, 21 Jun 2017 09:21:12 -0500
From:   "Steve Wise" <swise@...ngridcomputing.com>
To:     "'Leon Romanovsky'" <leon@...nel.org>,
        "'Doug Ledford'" <dledford@...hat.com>
Cc:     <linux-rdma@...r.kernel.org>,
        "'Chien Tin Tung'" <chien.tin.tung@...el.com>,
        "'Stephen Hemminger'" <stephen@...workplumber.org>,
        "'Jiri Pirko'" <jiri@...lanox.com>,
        "'Ariel Almog'" <ariela@...lanox.com>,
        "'Linux Netdev'" <netdev@...r.kernel.org>,
        "'Leon Romanovsky'" <leonro@...lanox.com>
Subject: RE: [PATCH rdma-next 13/19] RDMA/netlink: Add netlink device definitions to UAPI

> From: Leon Romanovsky <leonro@...lanox.com>
> 
> Introduce new defines to rdma_netlink.h, so the RDMA configuration tool
> will be able to communicate with RDMA subsystem by using the shared defines.
> 
> The addition of new client (NLDEV) revealed the fact that we exposed by
> mistake the RDMA_NL_I40IW define which is not backed by any RDMA netlink
> by now and it won't be exposed in the future too. So this patch reuses
> the value and leaves the comment together with old definition to whose
> who are using RDMA_NL_I40IW as a replacement for digit "5".
> 
> The NLDEV operates with objects. The struct ib_device has two straightforward
> objects: device itself and ports of that device.
> 
> This brings us to propose the following commands to work on those objects:
>  * RDMA_NLDEV_CMD_{GET,SET,NEW,DEL} - works on ib_device itself
>  * RDMA_NLDEV_CMD_PORT_{GET,SET,NEW,DEL} - works on ports of specific
> ib_device
> 
> Those commands receive/return the device name
> (RDMA_NLDEV_ATTR_DEV_NAME)
> and port index (RDMA_NLDEV_ATTR_PORT_INDEX). For device object accesses,
> the RDMA_NLDEV_ATTR_PORT_INDEX will return the maximum number of ports
> for specific ib_device and for port access the actual port index.
> 
> The port index starts from 1 to follow RDMA/core internal semantics and
> the sysfs exposed knobs..
> 
> Signed-off-by: Leon Romanovsky <leonro@...lanox.com>

Reviewed-by: Steve Wise <swise@...ngridcomputing.com>