netdev - Re: [PATCH rdma-next 17/19] RDMA/netlink: Add nldev port dumpit implementation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170621144211.GE1248@mtr-leonro.local>
Date:   Wed, 21 Jun 2017 17:42:11 +0300
From:   Leon Romanovsky <leon@...nel.org>
To:     Steve Wise <swise@...ngridcomputing.com>
Cc:     'Doug Ledford' <dledford@...hat.com>, linux-rdma@...r.kernel.org,
        'Chien Tin Tung' <chien.tin.tung@...el.com>,
        'Stephen Hemminger' <stephen@...workplumber.org>,
        'Jiri Pirko' <jiri@...lanox.com>,
        'Ariel Almog' <ariela@...lanox.com>,
        'Linux Netdev' <netdev@...r.kernel.org>
Subject: Re: [PATCH rdma-next 17/19] RDMA/netlink: Add nldev port dumpit
 implementation

On Wed, Jun 21, 2017 at 09:28:12AM -0500, Steve Wise wrote:
> > From: Leon Romanovsky <leonro@...lanox.com>
> >
> > This patch implements the query interface to get all
> > ports data for the specific device.
> >
> > Signed-off-by: Leon Romanovsky <leonro@...lanox.com>
>
> The fill_port/dev_info is just filling in names and indexes.  Shouldn't it have
> all kinds of goodies about the port/dev?  Will this be enhanced going forward as
> needed?

Yes, exactly.

>
> Reviewed-by: Steve Wise <swise@...ngridcomputing.com>

Thank you a lot for your review.

>
>

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)