netdev - Re: [PATCH net-next] bpf, i40e: Report bpf_prog id during XDP_QUERY

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAKgT0Ucr2WANKLhXFfo2wearoeeNAMqNATMXkVLwxbDtrwKs9A@mail.gmail.com>
Date:   Wed, 21 Jun 2017 11:23:34 -0700
From:   Alexander Duyck <alexander.duyck@...il.com>
To:     John Fastabend <john.fastabend@...il.com>
Cc:     Daniel Borkmann <daniel@...earbox.net>,
        David Miller <davem@...emloft.net>,
        Netdev <netdev@...r.kernel.org>, Martin KaFai Lau <kafai@...com>,
        Alexander Duyck <alexander.h.duyck@...el.com>
Subject: Re: [PATCH net-next] bpf, i40e: Report bpf_prog id during XDP_QUERY_PROG

On Wed, Jun 21, 2017 at 10:54 AM, John Fastabend
<john.fastabend@...il.com> wrote:
> On 06/21/2017 10:27 AM, Daniel Borkmann wrote:
>> Fill the bpf_prog with the id just like we do in other XDP enabled
>> drivers.
>>
>> Signed-off-by: Daniel Borkmann <daniel@...earbox.net>
>> Cc: Martin KaFai Lau <kafai@...com>
>> Cc: Alexander Duyck <alexander.h.duyck@...el.com>
>> ---
>>  drivers/net/ethernet/intel/i40e/i40e_main.c | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/net/ethernet/intel/i40e/i40e_main.c b/drivers/net/ethernet/intel/i40e/i40e_main.c
>> index 2db93d3..6f5adb5 100644
>> --- a/drivers/net/ethernet/intel/i40e/i40e_main.c
>> +++ b/drivers/net/ethernet/intel/i40e/i40e_main.c
>> @@ -9589,6 +9589,7 @@ static int i40e_xdp(struct net_device *dev,
>>               return i40e_xdp_setup(vsi, xdp->prog);
>>       case XDP_QUERY_PROG:
>>               xdp->prog_attached = i40e_enabled_xdp_vsi(vsi);
>> +             xdp->prog_id = xdp->prog_attached ? vsi->xdp_prog->aux->id : 0;
>>               return 0;
>>       default:
>>               return -EINVAL;
>>
>
> Looks good to me.
>
> Acked-by: John Fastabend <john.fastabend@...il.com>

My preference would be to test for vsi->xdp_prog instead of
xdp->prog_attached since it is more obvious what is going on in that
case. We might even want to look at getting rid of the call to
i40e_enabled_xdp_vsi eventually. But that is probably follow-up work
for later.

This should work assuming the RTNL lock is always held when this call is made.

Acked-by: Alexander Duyck <alexander.h.duyck@...el.com>