netdev - Re: [PATCH v2] net/sctp/ulpevent.c: Deinline sctp_ulpevent_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170621192442.GH18138@localhost.localdomain>
Date:   Wed, 21 Jun 2017 16:24:42 -0300
From:   Marcelo Ricardo Leitner <marcelo.leitner@...il.com>
To:     Denys Vlasenko <dvlasenk@...hat.com>
Cc:     linux-kernel@...r.kernel.org, Vlad Yasevich <vyasevich@...il.com>,
        Neil Horman <nhorman@...driver.com>,
        David Miller <davem@...emloft.net>, linux-sctp@...r.kernel.org,
        netdev@...r.kernel.org
Subject: Re: [PATCH v2] net/sctp/ulpevent.c: Deinline
 sctp_ulpevent_set_owner, save 1616 bytes

On Wed, Jun 21, 2017 at 07:03:27PM +0200, Denys Vlasenko wrote:
> This function compiles to 147 bytes of machine code. 13 callsites.
> 
> I'm no expert on SCTP events, but quick reading of SCTP docs tells me that
> SCTP events are not happening on every packet.
> They are ASSOC_CHANGE, PEER_ADDR_CHANGE, REMOTE_ERROR and such.
> Does not look performance critical.
> 
> Signed-off-by: Denys Vlasenko <dvlasenk@...hat.com>
> CC: Vlad Yasevich <vyasevich@...il.com>
> CC: Neil Horman <nhorman@...driver.com>
> CC: David Miller <davem@...emloft.net>
> CC: linux-sctp@...r.kernel.org
> CC: netdev@...r.kernel.org
> CC: linux-kernel@...r.kernel.org

Acked-by: Marcelo Ricardo Leitner <marcelo.leitner@...il.com>

Just wondering, are you conducting further research on this topic?
Because we probably could use such review on SCTP stack.

> ---
> Changed since v1:
> * reindented function argument list
> 
>  net/sctp/ulpevent.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/net/sctp/ulpevent.c b/net/sctp/ulpevent.c
> index ec2b3e0..bc3f495 100644
> --- a/net/sctp/ulpevent.c
> +++ b/net/sctp/ulpevent.c
> @@ -88,8 +88,8 @@ int sctp_ulpevent_is_notification(const struct sctp_ulpevent *event)
>  /* Hold the association in case the msg_name needs read out of
>   * the association.
>   */
> -static inline void sctp_ulpevent_set_owner(struct sctp_ulpevent *event,
> -					   const struct sctp_association *asoc)
> +static void sctp_ulpevent_set_owner(struct sctp_ulpevent *event,
> +				    const struct sctp_association *asoc)
>  {
>  	struct sctp_chunk *chunk = event->chunk;
>  	struct sk_buff *skb;
> -- 
> 1.8.3.1
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-sctp" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>