netdev - RE: [PATCH] net: fib: fix fib_new

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 21 Jun 2017 23:48:44 +0000
From:   YUAN Linyu <Linyu.Yuan@...atel-sbell.com.cn>
To:     Cong Wang <xiyou.wangcong@...il.com>, yuan linyu <cugyly@....com>
CC:     Linux Kernel Network Developers <netdev@...r.kernel.org>,
        "David S . Miller" <davem@...emloft.net>
Subject: RE: [PATCH] net: fib: fix fib_new_table() logical issue

Sorry, it's not dead loop, I realized it but I tried to send to mail to note it on my phone, it failed. 

> -----Original Message-----
> From: Cong Wang [mailto:xiyou.wangcong@...il.com]
> Sent: Thursday, June 22, 2017 6:54 AM
> To: yuan linyu
> Cc: Linux Kernel Network Developers; David S . Miller; YUAN Linyu
> Subject: Re: [PATCH] net: fib: fix fib_new_table() logical issue
> 
> On Wed, Jun 21, 2017 at 7:02 AM, yuan linyu <cugyly@....com> wrote:
> > From: yuan linyu <Linyu.Yuan@...atel-sbell.com.cn>
> >
> > when CONFIG_IP_MULTIPLE_TABLES defined,
> > if id == RT_TABLE_LOCAL and !net->ipv4.fib_has_custom_rules,
> > fib_new_table() call itself to get RT_TABLE_MAIN table,
> > but if RT_TABLE_MAIN table not exist at this point,
> > this function will become deadloop.
> 
> Why deadloop here? If fib_new_table() is called recursively,
> then main table is created by fib_trie_table() and we return.