netdev - Re: [RFC 1/2] net-next: fix DSA flow

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <e6570fed-3a8b-4d1b-ce0f-857ff000638a@phrozen.org>
Date:   Wed, 21 Jun 2017 06:33:25 +0200
From:   John Crispin <john@...ozen.org>
To:     Andrew Lunn <andrew@...n.ch>
Cc:     Vivien Didelot <vivien.didelot@...oirfairelinux.com>,
        Florian Fainelli <f.fainelli@...il.com>,
        "David S . Miller" <davem@...emloft.net>,
        Sean Wang <sean.wang@...iatek.com>, netdev@...r.kernel.org
Subject: Re: [RFC 1/2] net-next: fix DSA flow_disection



On 20/06/17 23:52, Andrew Lunn wrote:
>> On Tue, Jun 20, 2017 at 07:37:35PM +0200, John Crispin wrote:
>>
>>
>> On 20/06/17 16:01, Andrew Lunn wrote:
>>> On Tue, Jun 20, 2017 at 10:06:54AM +0200, John Crispin wrote:
>>>> RPS and probably other kernel features are currently broken on some if not
>>>> all DSA devices. The root cause of this that skb_hash will call the
>>>> flow_disector.
>>> Hi John
>>>
>>> What is the call path when the flow_disector is called? I'm wondering
>>> if we can defer this, and call it later, after the tag code has
>>> removed the header.
>>>
>>> 	Andrew
> Hi John
>
> I follow your logic of doing the hash early
>
> Is there any value in including the DSA header in the hash? That might
> allow frames from different ingress ports to be spread over CPUs?
>
>        Andrew
Hi Andrew,

adding the DSA header wont make any difference and would still require a 
patch to the flow dissector.

     John