netdev - Re: [PATCH v4 net-next 0/7] qed*: RDMA and infrastructure for iWARP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 21 Jun 2017 12:57:36 +0300
From:   Or Gerlitz <gerlitz.or@...il.com>
To:     David Miller <davem@...emloft.net>, Yuval.Mintz@...ium.com
Cc:     Linux Netdev List <netdev@...r.kernel.org>,
        Michal.Kalderon@...ium.com,
        "linux-rdma@...r.kernel.org" <linux-rdma@...r.kernel.org>
Subject: Re: [PATCH v4 net-next 0/7] qed*: RDMA and infrastructure for iWARP

On Wed, Jun 21, 2017 at 12:56 PM, Or Gerlitz <gerlitz.or@...il.com> wrote:
> On Tue, Jun 20, 2017 at 7:35 PM, David Miller <davem@...emloft.net> wrote:
>> From: Yuval Mintz <Yuval.Mintz@...ium.com>
>> Date: Tue, 20 Jun 2017 15:59:59 +0300
>>
>>> Please consider applying this series to `net-next'.
>>
>> Series applied, thanks.

Yuval,

It's broke my build

In file included from drivers/net/ethernet/qlogic/qede/qede.h:43,
                 from drivers/net/ethernet/qlogic/qede/qede_ethtool.c:41:
./include/linux/qed/qede_rdma.h:85: error: expected identifier or '('
before '{' token
In file included from drivers/net/ethernet/qlogic/qede/qede.h:43,
                 from drivers/net/ethernet/qlogic/qede/qede_dcbnl.c:13:
./include/linux/qed/qede_rdma.h:85: error: expected identifier or '('
before '{' token
make[5]: *** [drivers/net/ethernet/qlogic/qede/qede_dcbnl.o] Error 1

here's the fix

diff --git a/include/linux/qed/qede_rdma.h b/include/linux/qed/qede_rdma.h
index 1348a16..9904617 100644
--- a/include/linux/qed/qede_rdma.h
+++ b/include/linux/qed/qede_rdma.h
@@ -81,7 +81,7 @@ void qede_rdma_dev_remove(struct qede_dev *dev);
 void qede_rdma_event_changeaddr(struct qede_dev *edr);

 #else
-static inline int qede_rdma_dev_add(struct qede_dev *dev);
+static inline int qede_rdma_dev_add(struct qede_dev *dev)
 {
        return 0;
 }