netdev - Re: [PATCH net-next V2] ibmvnic: Correct return code checking for ibmvnic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20170622.113240.459131569663342510.davem@davemloft.net>
Date:   Thu, 22 Jun 2017 11:32:40 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     nfont@...ux.vnet.ibm.com
Cc:     netdev@...r.kernel.org, jallen@...ux.vnet.ibm.com,
        tlfalcon@...ux.vnet.ibm.com
Subject: Re: [PATCH net-next V2] ibmvnic: Correct return code checking for
 ibmvnic_init during probe

From: Nathan Fontenot <nfont@...ux.vnet.ibm.com>
Date: Wed, 21 Jun 2017 15:41:02 -0500

> The update to ibmvnic_init to allow an EAGAIN return code broke
> the calling of ibmvnic_init from ibmvnic_probe. The code now
> will return from this point in the probe routine if anything
> other than EAGAIN is returned. The check should be to see if rc
> is non-zero and not equal to EAGAIN.
> 
> Without this fix, the vNIC driver can return 0 (success) from
> its probe routine due to ibmvnic_init returning zero, but before
> completing the probe process and registering with the netdev layer.
> 
> Fixes: 6a2fb0e99f9c (ibmvnic: driver initialization for kdump/kexec)
> Signed-off-by: Nathan Fontenot <nfont@...ux.vnet.ibm.com>

Applied.