netdev - Re: [PATCH net-next v3 06/13] sock: MSG_ZEROCOPY notification coalescing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20170622.130741.873016534812693988.davem@davemloft.net>
Date:   Thu, 22 Jun 2017 13:07:41 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     willemdebruijn.kernel@...il.com
Cc:     netdev@...r.kernel.org, linux-api@...r.kernel.org,
        willemb@...gle.com
Subject: Re: [PATCH net-next v3 06/13] sock: MSG_ZEROCOPY notification
 coalescing

From: Willem de Bruijn <willemdebruijn.kernel@...il.com>
Date: Wed, 21 Jun 2017 17:18:09 -0400

> +static bool skb_zerocopy_notify_extend(struct sk_buff *skb, u32 lo, u16 len)
> +{
> +	struct sock_exterr_skb *serr = SKB_EXT_ERR(skb);
> +	u64 sum_len;
> +	u32 old_lo, old_hi;

Reverse christmas tree.

>  void sock_zerocopy_callback(struct ubuf_info *uarg, bool success)
>  {
>  	struct sock_exterr_skb *serr;
> -	struct sk_buff *skb = skb_from_uarg(uarg);
> +	struct sk_buff *tail, *skb = skb_from_uarg(uarg);
>  	struct sock *sk = skb->sk;
> -	u16 id = uarg->desc;
> +	struct sk_buff_head *q = &sk->sk_error_queue;
> +	unsigned long flags;
> +	u32 lo, hi;
> +	u16 len;

Likewise.