netdev - Re: [PATCH net] udp: ipv6: reset daddr and dport in sk if connect() fails

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 23 Jun 2017 01:46:16 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Wei Wang <tracywwnj@...il.com>
Cc:     kbuild-all@...org, David Miller <davem@...emloft.net>,
        netdev@...r.kernel.org,
        Subash Abhinov Kasiviswanathan <subashab@...eaurora.org>,
        Maciej Żenczykowski <maze@...gle.com>,
        Wei Wang <weiwan@...gle.com>
Subject: Re: [PATCH net] udp: ipv6: reset daddr and dport in sk if connect()
 fails

Hi Wei,

[auto build test ERROR on net/master]

url:    https://github.com/0day-ci/linux/commits/Wei-Wang/udp-ipv6-reset-daddr-and-dport-in-sk-if-connect-fails/20170623-011149
config: xtensa-allyesconfig (attached as .config)
compiler: xtensa-linux-gcc (GCC) 4.9.0
reproduce:
        wget https://raw.githubusercontent.com/01org/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        make.cross ARCH=xtensa 

All errors (new ones prefixed by >>):

   net//ipv6/datagram.c: In function '__ip6_datagram_connect':
>> net//ipv6/datagram.c:257:30: error: expected ')' before 'sizeof'
      memset(&sk->sk_v6_daddr, 0 sizeof(sk->sk_v6_daddr);
                                 ^
>> net//ipv6/datagram.c:257:3: error: too few arguments to function 'memset'
      memset(&sk->sk_v6_daddr, 0 sizeof(sk->sk_v6_daddr);
      ^
   In file included from include/linux/string.h:18:0,
                    from include/linux/bitmap.h:8,
                    from include/linux/cpumask.h:11,
                    from include/linux/interrupt.h:9,
                    from net//ipv6/datagram.c:18:
   arch/xtensa/include/asm/string.h:110:14: note: declared here
    extern void *memset(void *__s, int __c, size_t __count);
                 ^
>> net//ipv6/datagram.c:260:2: error: expected ';' before '}' token
     }
     ^

vim +257 net//ipv6/datagram.c

   251	
   252		err = ip6_datagram_dst_update(sk, true);
   253		if (err) {
   254			/* Reset daddr and dport so that udp_v6_early_demux()
   255			 * fails to find this socket
   256			 */
 > 257			memset(&sk->sk_v6_daddr, 0 sizeof(sk->sk_v6_daddr);
   258			inet->inet_dport = 0;
   259			goto out;
 > 260		}
   261	
   262		sk->sk_state = TCP_ESTABLISHED;
   263		sk_set_txhash(sk);

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (50281 bytes)