netdev - Re: [RFC PATCH net-next 3/3] net/mlx5e: Expose link down reason to ethtool

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6c8de38c-5df4-279e-f653-4efd822f6dad@gmail.com>
Date:   Thu, 22 Jun 2017 11:17:13 +0300
From:   Gal Pressman <galp.dev@...il.com>
To:     Andrew Lunn <andrew@...n.ch>, Gal Pressman <galp@...lanox.com>
Cc:     netdev@...r.kernel.org, "David S. Miller" <davem@...emloft.net>,
        "John W. Linville" <linville@...driver.com>,
        Saeed Mahameed <saeedm@...lanox.com>,
        Vidya Sagar Ravipati <vidya@...ulusnetworks.com>,
        Jiri Pirko <jiri@...lanox.com>,
        David Decotigny <decot@...glers.com>, kernel-team@...com
Subject: Re: [RFC PATCH net-next 3/3] net/mlx5e: Expose link down reason to
 ethtool


>> +	if (!netif_running(netdev)) {
>> +		ldr->reason = ETHTOOL_LINK_NETDEV_CARRIER_DOWN;
>> +		return 0;
>> +	}
> This is generic, will work for any interface. The same is true for
> ADMIN_DOWN. Either it is not required at all, since the information is
> available via other means, or it should be in the core.

I agree, will move it to the core.

>
> 	  Andrew