netdev - Re: [PATCH net v2 2/2] esp6_offload: Fix IP6CB(skb)->nhoff for ESP GRO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170622105213.GW2631@secunet.com>
Date:   Thu, 22 Jun 2017 12:52:13 +0200
From:   Steffen Klassert <steffen.klassert@...unet.com>
To:     <yossiku@...lanox.com>
CC:     <netdev@...r.kernel.org>, Herbert Xu <herbert@...dor.apana.org.au>,
        Yevgeny Kliteynik <kliteyn@...lanox.com>,
        Boris Pismenny <borisp@...lanox.com>,
        Ilan Tayari <ilant@...lanox.com>
Subject: Re: [PATCH net v2 2/2] esp6_offload: Fix IP6CB(skb)->nhoff for ESP
 GRO

On Thu, Jun 22, 2017 at 11:37:11AM +0300, yossiku@...lanox.com wrote:
> From: Yossi Kuperman <yossiku@...lanox.com>
> 
> IP6CB(skb)->nhoff is the offset of the nexthdr field in an IPv6
> header, unless there are extension headers present, in which case
> nhoff points to the nexthdr field of the last extension header.
> 
> In non-GRO code path, nhoff is set by ipv6_rcv before any XFRM code
> is executed. Conversely, in GRO code path (when esp6_offload is loaded),
> nhoff is not set. The following functions fail to read the correct value
> and eventually the packet is dropped:
> 
>     xfrm6_transport_finish
>     xfrm6_tunnel_input
>     xfrm6_rcv_tnl
> 
> Set nhoff to the proper offset of nexthdr in esp6_gro_receive.
> 
> Fixes: 7785bba299a8 ("esp: Add a software GRO codepath")
> Signed-off-by: Yossi Kuperman <yossiku@...lanox.com>

Both patches applied, thanks for your work Yossi!