netdev - Re: [PATCH net-next 0/8] xdp: offload mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 23 Jun 2017 13:42:39 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     jakub.kicinski@...ronome.com
Cc:     netdev@...r.kernel.org, oss-drivers@...ronome.com, kafai@...com,
        daniel@...earbox.net
Subject: Re: [PATCH net-next 0/8] xdp: offload mode

From: Jakub Kicinski <jakub.kicinski@...ronome.com>
Date: Wed, 21 Jun 2017 18:25:02 -0700

> While we discuss the representors.. :)
> 
> This set adds XDP flag for forcing offload and a attachment mode
> for reporting to user space that program has been offloaded.  The
> nfp driver is modified to make use of the new flags, but also to
> adhere to the DRV_MODE flag which should disable the HW offload.
> 
> The intended driver behaviour is:
>             DRV mode   offload
> no flags      yes     attempted
> DRV_MODE      yes        no
>  HW_MODE      no         yes
> 
> Where 'yes' means required, and error will be returned if setup fails.
> 'Attempted' means the offload will only happen automatically if HW is
> capable and offloading the program will cause no change in system
> behaviour (e.g. maps don't have to bound).
> 
> Thanks to loading the program both to the driver and HW by default we
> can fallback to the driver mode without disruption in case user replaces
> the program with one which cannot be offloaded later.
> 
> Note that the NFP driver currently claims XDP offload support but 
> lacks most basic features like direct packet access.
> 
> Only change compared to the RFC is fixing the double bpf_prog_put()
> which Daniel has spotted (patch 5).

Applied, thank you.