netdev - Re: [PATCH net-next] tcp: fix out-of-bounds access in ULP sysctl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20170623.141017.620234771116563109.davem@davemloft.net>
Date:   Fri, 23 Jun 2017 14:10:17 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     jakub.kicinski@...ronome.com
Cc:     netdev@...r.kernel.org, borisp@...lanox.com, davejwatson@...com,
        oss-drivers@...ronome.com
Subject: Re: [PATCH net-next] tcp: fix out-of-bounds access in ULP sysctl

From: Jakub Kicinski <jakub.kicinski@...ronome.com>
Date: Thu, 22 Jun 2017 18:57:55 -0700

> KASAN reports out-of-bound access in proc_dostring() coming from
> proc_tcp_available_ulp() because in case TCP ULP list is empty
> the buffer allocated for the response will not have anything
> printed into it.  Set the first byte to zero to avoid strlen()
> going out-of-bounds.
> 
> Fixes: 734942cc4ea6 ("tcp: ULP infrastructure")
> Signed-off-by: Jakub Kicinski <jakub.kicinski@...ronome.com>

Applied, thanks.